Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

Various fixes#1075

Merged
igchor merged 3 commits intopmem:masterfrom
lukaszstolarczuk:various-fixes
May 19, 2021
Merged

Various fixes#1075
igchor merged 3 commits intopmem:masterfrom
lukaszstolarczuk:various-fixes

Conversation

@lukaszstolarczuk
Copy link
Copy Markdown
Member

@lukaszstolarczuk lukaszstolarczuk commented May 18, 2021

minor fixes in different places


This change is Reviewable

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2021

Codecov Report

Merging #1075 (3ac2a7e) into master (7b9e9f0) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1075      +/-   ##
==========================================
+ Coverage   94.03%   94.05%   +0.02%     
==========================================
  Files          49       49              
  Lines        4726     4726              
==========================================
+ Hits         4444     4445       +1     
+ Misses        282      281       -1     
Flag Coverage Δ
tests_clang_debug_cpp17 93.51% <ø> (+0.11%) ⬆️
tests_gcc_debug 91.72% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/libpmemobj++/condition_variable.hpp 73.80% <0.00%> (-2.39%) ⬇️
...ude/libpmemobj++/container/concurrent_hash_map.hpp 94.51% <0.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b9e9f0...3ac2a7e. Read the comment docs.

Copy link
Copy Markdown
Contributor

@igchor igchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 4 files reviewed, all discussions resolved

@igchor igchor merged commit 49067ef into pmem:master May 19, 2021
@lukaszstolarczuk lukaszstolarczuk deleted the various-fixes branch May 19, 2021 08:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants